Updates from Matt Harzewski Toggle Comment Threads | Keyboard Shortcuts

  • Matt Harzewski 8:50 pm on August 13, 2010 Permalink | Reply  

    Comment Improvements – Week #12 

    I didn’t really do anything this week. It’s been a long twelve weeks and, though I wish I had managed to get more work in, I think I’ve been having some burnout issues. 😦

    Most of the functionality is mainly there though, and the UI is passable. Perhaps not quite production ready, but it’s usable. I didn’t get around to working on updating the AJAX callbacks for the threaded comments, so editing or replying to child messages will cause the whole table row to be overwritten with a single flat comment. That’s the only glaring omission though.

     
  • Matt Harzewski 8:38 pm on August 6, 2010 Permalink | Reply  

    Comment Improvements – Week #11 

    It’s been a fairly unproductive week for me. I did some minor UI tweaks, but nothing too serious. Things are starting to look a bit better, progress-wise, though. The project has come a long way since the days of being print_r() junk.

    And that scary deadline is getting closer than I would like. 🙂

     
  • Matt Harzewski 6:12 pm on July 30, 2010 Permalink | Reply  

    Comment Improvements – Week #10 

    This week I fixed something that I broke. 🙂

    The colspans that I used as part of the threaded comments were breaking the table if the Screen Options were changed to reduce the number of columns (e.g. turning the “Author” column off). I made a few changes, including a bit of JavaScript that recalculates the colspan values when the Screen Options are changed.

     
  • Matt Harzewski 7:20 pm on July 23, 2010 Permalink | Reply  

    Comment Improvements – Week #9 

    I’ve been kind of taking a break this week, but I did a little bit of experimenting with the CSS that makes the row-actions links appear when you mouseover a comment in the moderation. As I mentioned in last week’s post, they appear for all of the comments in a thread at once. I’ve been trying to get them to only show for the one the mouse is directly over, with little success. Nested lists are a pain to style properly…

     
  • Matt Harzewski 4:50 pm on July 16, 2010 Permalink | Reply  

    Comment Improvements – Week #8 

    As of the end of this week, there are now functioning comments in the admin. Still a bit of UI work to do, but the headache-inducing part is hopefully over. 🙂

    The row-actions links appear on mouseover, and seem to function properly, though they currently show for all of the replies to a comment at once. (I’ll have to fix that.)

     
  • Matt Harzewski 3:20 pm on July 9, 2010 Permalink | Reply  

    Comment Improvements – Week #7 

    I feel like I got a bit done with week. I went from an unstyled Walker_Comment list to a table that looks and exacts just like the unthreaded one in the WordPress proper. I still have to figure out how to the Walker classes do their threading magic and implement it though.

    I fixed the SQL query in one of the comment rethreading functions I wrote so it doesn’t return rows for comments in the Trash. It’s probably not a good idea to change the parent of a published comment to one that’s in the trash…

    Also, I talked to Filosofo a bit about some stuff, the comment threading in particular.

    Oh, and sorry about the delay for last week’s post. Somehow the status got set to Draft instead of Published and it didn’t go up. I fixed it now, though.

     
  • Matt Harzewski 9:18 pm on July 2, 2010 Permalink | Reply  

    Comment Improvements – Week #6 

    This week I started hacking together a modified version of the Walker_Comment class, named Admin_Walker_Comment, which I am planning on using for threaded comments in the administration. It’s just outputting an unordered list of comments so far, as I haven’t gotten too far yet, but I think I have figured out how I want to handle a part of it that has been bothering me.

    Edit: Oops, it looks like I forgot to set the status to “Published” somehow. Sorry about the delay… 😦

     
  • Matt Harzewski 10:15 pm on June 25, 2010 Permalink | Reply  

    Comment Improvements – Week #5 

    It was suggested by Beau Lebens that replying to an unapproved comment (through the administration) should automatically cause the comment to become approved. The idea being that it makes absolutely no sense for an editor/admin to reply to a comment that they wouldn’t want to be approved.

    So I ended up working on building the functionality in. I had to muck around with JavaScript a bit, in order to apply the spiffy jQuery effects WordPress uses to make the changes apparent to the user.

    I have not yet minified the .dev.js file into the production version. (So the SCRIPT_DEBUG constant needs to be true for it to work.) Does anyone know the best way to go about doing that?

     
    • Andrew Nacin 10:20 pm on June 25, 2010 Permalink | Reply

      We use YUI Compressor (munge optional). Personally, I wouldn’t worry about it, as they simply get stale very quickly. (We do it on commit and recommend they aren’t included in patches, FWIW.)

      • Matt Harzewski 11:40 pm on June 28, 2010 Permalink | Reply

        Okay. I won’t worry about it then. I have to experiment with some of the YUI stuff sometime. It’s pretty interesting.

  • Matt Harzewski 4:33 pm on June 18, 2010 Permalink | Reply  

    Comment Improvements – Week #4 

    I think I have pretty much finished the “comment re-threading” feature that I have been working on. This week I scrapped the comment row link trigger I was working on in favor of something that makes a lot more sense form a UI standpoint: a new form element on the Edit Comment screen.

    A new selectbox let’s you move a comment anywhere in the hierarchy.

    This function is something that I’ve wanted to see in WordPress ever since threaded comments were introduced. (Was that 2.7 or 2.8?) An annoyingly large percentage of users still can’t seem to grasp the concept of clicking the “reply” button to respond to the correct comment…

     
    • Beau Lebens 6:50 pm on June 18, 2010 Permalink | Reply

      I don’t see it on https://gsoc2010.wordpress.com/matt-harzewski-comments/ but it’d be awesome if you could also add a patch that would automatically approve a pending comment if you reply to it (since that seems like assumed behavior, but currently isn’t). Don’t let me inflate your project’s scope, but seems like a good one if you have time 😉

      • redwall_hp 7:07 pm on June 19, 2010 Permalink | Reply

        I’ll think about it. Your suggestion does make sense. I’m actually surprised that WordPress doesn’t already do that…

  • Matt Harzewski 8:57 pm on June 11, 2010 Permalink | Reply  

    Comment Improvements – Week #3 

    I did some preliminary work for “comment re-threading.” I created a function (as of yet untested) to change the comment parent in the database. Also, I began work on the UI end, creating a new “Re-thread” link in the comment rows. I’m still trying to track down the JavaScript responsible for handling click events on the .row-actions links though, so it doesn’t do anything quite yet.

    I hope I’ll be able to get more done this coming week, especially since I have the incentive of just having received my payment card. Carrots-on-sticks work… 🙂

     
c
Compose new post
j
Next post/Next comment
k
Previous post/Previous comment
r
Reply
e
Edit
o
Show/Hide comments
t
Go to top
l
Go to login
h
Show/Hide help
shift + esc
Cancel